count string length correctly in OpenAPI validators #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sunli829 |
|
Hi! I want to leave an extra remark. The proposed implementation assumes that character in Unicode string is the same as Unicode code point, which, I think, is pretty reasonable in the context of web APIs. However, I am not completely sure it is precisely JSON Schema / JSON specs' interpretation. (For example, is Indonesian flag emoji 🇮🇩 one character or two?) |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the poem's OpenAPI module, derived maxLength and minLength validators use
str::len()method, which counts UTF-8 bytes, not Unicode characters in string. While JSON Schema spec defines maxLength and minLength for number of characters.This pull request fixes that, also adding extra couple unit tests to better cover edge cases.